Hi Alan, > I can see what the information tags might be grouped but @library and > @modules should also be grouped with the @compile/@run/@build).
from my point of view, there are 3 different groups of tags: - information tags: @test, @bug, @key, @summary, @author. these tags describe a test, some of them can be used for test selection, but they do not affect test execution. - declarative tags: @library, @modules, @requires. they change how a test is executed, but they don't specify any test actions - imperative tags: @run and all its shortcuts -- @compile, @build, @ignore. these tags are action tags, their order is important, and they basically define that a test does. I use empty lines to separate these groups, so it will be easier to maintain tests. for example in past, we had problems with tests which have @ignore tag placed before @library tag. if we had had this separation, a chance to make such mistakes would have been much lower. > What is the reason to put empty lines between the @modules and @library tags? there should be not lines b/w @modules and @library, in what test do you see it? -- Igor > On Mar 23, 2017, at 12:18 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 22/03/2017 20:09, Igor Ignatyev wrote: > >> http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html >>> 40 lines changed: 26 ins; 13 del; 1 mod; >> Hi all, >> >> could you please review this changeset which fixes in a few jdk_svc tests >> which were missed by JDK-8176176[1]? >> >> testing: :jdk_svc tests >> webrev: http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html >> JBS: https://bugs.openjdk.java.net/browse/JDK-8177374 >> > The updated @summary tag for test/com/sun/tools/attach/BasicTests.java looks > really ugly now. Personally I think I would put the summary at the end and > intent the second line to make it easier to read. > > I also see lots of random empty lines introduced. What is the reason to put > empty lines between the @modules and @library tags? I can see what the > information tags might be grouped but @library and @modules should also be > grouped with the @compile/@run/@build). > > -Alan
