Hi Ujwal,
The fix looks fine.
Some nits.
In ClientNotifForwarder.java, "getListenerIds" could be renamed to
getClientListenrIds.
-Harsha
On Thursday 04 May 2017 12:29 PM, Ujwal Vangapally wrote:
corrected webrev link :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/6515161/webrev.00/
On 5/4/2017 12:14 PM, Ujwal Vangapally wrote:
Kindly review the changes made for below bug
Problem description and solution are explained in comments section
https://bugs.openjdk.java.net/browse/JDK-6515161
diff for*ClientNotifForwarder.java *might be a bit confusing as it
shows the method name
removeNotificationListener is modified to getListenerIds and new
method removeNotificationListener is introduced.
Actual change is new method getListenerIds is introduced and it is
called in removeNotificationListener method without
affecting the functionality of removeNotificationListener.
webrev : cr.openjdk.java.net/~uvangapally/webrev/2017/6515161/webrev.00/
Thanks,
Ujwal,
