Thanks for the review Mandy.
updated webrev with simplified version using @requires os.simpleArch=="x64".
can't use @requires (os.family != "windows") | (os.simpleArch !=
"i586")alone as sometimes it might fail on Linux 32bit as well
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8178508/webrev.03/
-Ujwal
On 6/14/2017 7:18 AM, Mandy Chung wrote:
On Jun 13, 2017, at 1:39 AM, Ujwal Vangapally
<[email protected] <mailto:[email protected]>> wrote:
Hi Mandy,
made multi-line @summary as last tag.
yes it was simpler before and we can use '@requires only 64 bit', but
we won't be able to verify it on Linux 32 bit in this case.
As it is possible to run -Xmx3000M on Linux 32 bit machines most of
the time but can't guarantee it all the time.
Hence used ProcessTools.executeTestJava() to make decision about
using -Xmx3000M.
I think it would be better if we can make Test run on Linux 32 bit
machine also.
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8178508/webrev.02/
I still prefer the simplified version to use jtreg @requires to
specify the platforms it should run on, like you suggest to use
@requires (os.family != "windows") | (os.simpleArch != "i586")
Mandy
