Thanks Christoph, Any offers for another reviewer of this fix please, it's only a few lines of code change. Thanks Andrew
Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: [email protected] From: "Langer, Christoph" <[email protected]> To: "[email protected]" <[email protected]> Date: 03/07/2017 08:25 Subject: RE: RFR 8183123 : JDP packets have no processId context set Sent by: "serviceability-dev" <[email protected]> Hi, Ping: Can we please get another review for this rather small JDK 10 fix? Thanks Christoph From: serviceability-dev [ mailto:[email protected]] On Behalf Of Andrew Leonard Sent: Donnerstag, 29. Juni 2017 15:57 To: [email protected] Subject: RFR 8183123 : JDP packets have no processId context set Hi All, Please can I get some review feedback for my changes for this issue: https://bugs.openjdk.java.net/browse/JDK-8183123 The webrev patch has been uploaded here: http://cr.openjdk.java.net/~clanger/webrevs/8183123.0/ Essentially the fix entails: - Replacing invalid process id query logic with call to ProcessHandle.current().getPid(). - Update testcase to cover the failing scenario. Thus it fails without my patch, and succeeds with it. Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: [email protected] Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
