Thanks for the review Bernd.
Test will just ensure that MemoryMXBean.gc() has made it's call to JVM
to invoke gc.
As we can't ensure that gc will be invoked by JVM by calling
MemoryMXBean.gc(), test shouldn't fail for that reason.
GC cause can be different form system.gc, but not sure whether a new gc
cause is required.
Perhaps we can wait for inputs from other reviewers.
Thanks,
Ujwal.
On 7/19/2017 11:31 AM, Bernd Eckenfels wrote:
This is cool, I have two minor comments: can it use a different/new GC
Cause and the test does actually not assert failed executions.
Gruss
Bernd
--
http://bernd.eckenfels.net
------------------------------------------------------------------------
*From:* serviceability-dev
<[email protected]> on behalf of Ujwal
Vangapally <[email protected]>
*Sent:* Wednesday, July 19, 2017 7:20:12 AM
*To:* serviceability-dev
*Subject:* RFR: JDK-6396411 java.lang.management.MemoryMXBean.gc
should force GC even if DisableExplicitGC is set
Hi,
Kindly review the fix
https://bugs.openjdk.java.net/browse/JDK-6396411
webrev:
http://cr.openjdk.java.net/~uvangapally/webrev/2017/6396411/webrev.00/
<http://cr.openjdk.java.net/%7Euvangapally/webrev/2017/6396411/webrev.00/>
Thanks,
Ujwal.
