On 07/17/2017 02:07 PM, Roman Kennke wrote:
Ok, added those and some more that I found. Not sure why we'd need #include "gc/cms/concurrentMarkSweepGeneration.hpp" ? Left that out for now.Because you are accessing CMSCollcetor in: 99 NOT_PRODUCT( 100 virtual size_t skip_header_HeapWords() { return CMSCollector::skip_header_HeapWords(); } 101 ) and CMSCollector is declared in concurrentMarkSweepGeneration.hpp. An alternative would of course be to just declare skip_header_HeapWords() in cmsHeap.hpp and define skip_header_HeapWords in cmsHeap.cpp, then you only need to include concurrentMarkSweeoGeneration.hpp in cmsHeap.cpp.Ah ok, I've missed that one. Added it now.
Where did you add it? I don't see any include of "gc/cms/concurrentMarkSweepGeneration.hpp" in cmsHeap.hpp? Thanks, Erik
