Re: [10] RFR (XS): 8185930: TEST_BUG: jvmti tests should not depend on the jdk.jdi module

[David Holmes]

Seems reasonable. :)

Thanks,
David

On 8/08/2017 8:21 AM, serguei.spit...@oracle.com wrote:

Please, review a two-lines fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8185930

The fix is to remove the unneeded dependecies on the jdk.jdi module.

The patch is:

diff -r f2ec523d900b test/serviceability/jvmti/GetNamedModule/MyPackage/GetNamedModuleTest.java --- a/test/serviceability/jvmti/GetNamedModule/MyPackage/GetNamedModuleTest.java Mon Aug 07 12:34:21 2017 -0700 +++ b/test/serviceability/jvmti/GetNamedModule/MyPackage/GetNamedModuleTest.java Mon Aug 07 15:12:19 2017 -0700

@@ -26,7 +26,6 @@
  /**
   * @test
   * @summary Verifies the JVMTI GetNamedModule API
- * @modules jdk.jdi
   * @compile GetNamedModuleTest.java

* @run main/othervm/native -agentlib:GetNamedModuleTest MyPackage.GetNamedModuleTest

   */

diff -r f2ec523d900b test/serviceability/jvmti/IsModifiableModule/MyPackage/IsModifiableModuleTest.java --- a/test/serviceability/jvmti/IsModifiableModule/MyPackage/IsModifiableModuleTest.java Mon Aug 07 12:34:21 2017 -0700 +++ b/test/serviceability/jvmti/IsModifiableModule/MyPackage/IsModifiableModuleTest.java Mon Aug 07 15:12:19 2017 -0700

@@ -26,7 +26,6 @@
  /**
   * @test
   * @summary Verifies the JVMTI IsModifiableModule API
- * @modules jdk.jdi
   * @compile IsModifiableModuleTest.java

* @run main/othervm/native -agentlib:IsModifiableModuleTest MyPackage.IsModifiableModuleTest

   */


Thanks,
Serguei