Thank you, David. Makes sense to not rush through the review. Since this
is not an integration blocker now, I will wait for the reviews for this
fix to go through, and not revert to PT_ATTACH (which causes the
build-time deprecation warnings).
Regards,
Jini.
On 8/18/2017 4:30 PM, David Holmes wrote:
Hi Jini,
Just reading the bug report and your description below this seems like
a major change to try and use a facility (mach exceptions) that no one
seems to have any experience with! That isn't something to be rushed.
Even if PT_ATTACH has been deprecated restoring its use may be the
quick way forward instead of trying to rush in something like this.
Just my 2c.
Cheers,
David
On 18/08/2017 8:00 PM, Jini George wrote:
Hi all,
Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8184042
Webrev: http://cr.openjdk.java.net/~jgeorge/8184042/webrev.00/
Problem gist: The deprecated ptrace() command, PT_ATTACH was changed
to PT_ATTACHEXC, which causes mach exceptions (and not UNIX signals)
to be delivered via mach messages.This caused SA to hang at waitpid()
waiting for a signal, which does not arrive.
Solution in a nutshell: The solution is to make the required changes
to handle mach 'soft signal' exceptions in the form of mach messages
instead of signals, while attaching to and detaching from the target
process. The detailed steps are outlined in JBS.
The changes appear huge due to the inclusion of pre-generated mach
exception handling files (mach_exc*). Since this is an integration
blocker, it would be great to get quick reviews on this.
Thank you,
Jini.
