Hi Ujwal, the changes look good to me.
Best regards Christoph > -----Original Message----- > From: serviceability-dev [mailto:serviceability-dev- > boun...@openjdk.java.net] On Behalf Of Ujwal Vangapally > Sent: Freitag, 25. August 2017 20:37 > To: serviceability-dev@openjdk.java.net > Subject: Re: RFR : JDK-8186224 > javax/management/remote/mandatory/subjectDelegation/* fail with > java.security.AccessControlException > > Can someone please review the changes, I need a second reviewer. > > Thanks, > > Ujwal. > > > On 8/24/2017 9:59 PM, Ujwal Vangapally wrote: > > Thanks for the Review Harsha. > > > > -Ujwal. > > > > On 8/24/2017 2:13 PM, Harsha Wardhana B wrote: > >> Hi Ujwal, > >> > >> The changes look good. > >> > >> Thanks > >> > >> Harsha > >> > >> > >> On Tuesday 22 August 2017 02:11 PM, Ujwal Vangapally wrote: > >>> Kindly review the changes made. > >>> > >>> Before these changes tests fail on windows if we execute them from > >>> any Drive other than C. > >>> > >>> grant codebase "file:/-" {} is granting permissions only to code > >>> present in C Drive on windows. > >>> > >>> Hence changing 'grant codebase "file:/-" {} ' to grant {} will > >>> solve the issue by giving permissions to all drives. > >>> > >>> > >>> https://bugs.openjdk.java.net/browse/JDK-8186224 > >>> > >>> webrev: > >>> > http://cr.openjdk.java.net/~uvangapally/webrev/2017/8186224/webrev.00/ > >>> > >>> > >>> Thanks, > >>> > >>> Ujwal. > >>> > >> > >
