Re: RFR (XS): 8173936 [TESTBUG] test/serviceability/jvmti/ModuleAwareAgents/ClassFileLoadHook/MAAClassFileLoadHook.java needs to be re-examined

[serguei.spit...@oracle.com]

Hi David,


On 10/16/17 23:24, David Holmes wrote:

Hi Serguei,

On 17/10/2017 3:35 PM, serguei.spit...@oracle.com wrote:

Please, review a fix for the test bug:
https://bugs.openjdk.java.net/browse/JDK-8173936


Webrev:

http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8173936-MAA-cflh.1/

Summary:

   This test expects CFLH events in the JVMTI start phase but it no longer gets these events because    the Jigsaw implementation has changed in a way that no longer loads any classes in this phase

   unless the capability can_generate_early_vmstart is enabled.

   The fix is to expect CFLH events in the JVMTI start phase only if this capability is enabled.

That description confused me somewhat but now I get it. :) The class the test is looking for is not loaded in the "start phase" now but in the "primordial phase" - unless you set the can_generate_early_vmstart capability to move the start phase back to where it used to be.

Right.
Sorry, I was not explicit about it.

Okay - seems fine.

Thank you a lot for quick review!

Thanks,
Serguei

Thanks,
David

Testing:

   The fixed test ClassFileLoadHook/MAAClassFileLoadHook.java is passed now.

Thanks,
Serguei