On 2/11/2017 4:19 PM, Shafi Ahmad wrote:
Hi All,
May get the second review for this backport.
Not sure a second one is needed for a backport like this, but I concur
with Daniel that the changes match the original changeset. :)
Thanks,
David
Regards,
Shafi
-----Original Message-----
From: Daniel Fuchs
Sent: Wednesday, October 25, 2017 2:34 PM
To: Shafi Ahmad <[email protected]>; serviceability-
[email protected]
Cc: David Holmes <[email protected]>
Subject: Re: [8u] RFR for backport of JDK-8177721: Improve diagnostics in
sun.management.Agent#startAgent()
Hi Shafi,
If I compare your webrev [1] with the JDK 9 changeset [2] then this looks OK
to me.
best regards,
-- daniel
[1] http://cr.openjdk.java.net/~shshahma/8177721/jdk8u/webrev.00/
[2] http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/9c9b8a48cd4a
On 25/10/2017 09:11, Shafi Ahmad wrote:
Hi,
Please review the backport of "JDK-8177721: Improve diagnostics in
sun.management.Agent#startAgent()" to jdk8u-dev.
The backport is not clean as I got the below conflict.
shshahma@slc12kkg:/scratch/shshahma/Java/jdk8u-dev/jdk$ cat
src/share/classes/sun/management/Agent.java.rej
--- Agent.java
+++ Agent.java
@@ -665,18 +665,6 @@
throw new RuntimeException(keyText);
}
- public static void error(String key, String[] params) {
- if (params == null || params.length == 0) {
- error(key);
- } else {
- StringBuilder message = new StringBuilder(params[0]);
- for (int i = 1; i < params.length; i++) {
- message.append(' ').append(params[i]);
- }
- error(key, message.toString());
- }
- }
-
public static void error(String key, String message) {
String keyText = getText(key);
System.err.print(getText("agent.err.error") + ": " +
keyText);
Webrev:
http://cr.openjdk.java.net/~shshahma/8177721/jdk8u/webrev.00/
Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8177721
Jdk9 review:
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-April/0
21188.html
Testing: jprt and jtreg test.
Regards,
Shafi
