Re: RFR: SA: JDK-8189798: SA cleanup - part 1

Tue, 07 Nov 2017 01:26:27 -0800 

Thank you very much, Sharath, for the review. My response inline:

On 11/3/2017 3:44 PM, Sharath Ballal wrote:

Hi Jini,

You have appended 'Field' for most of the SA variables.  Example:

private static CIntegerField pcOffsetField;
pcOffsetField = type.getCIntegerField("_pc_offset");

However that is not the case in
private static long MinChunkSizeInBytes;
MinChunkSizeInBytes = 
(type.getCIntegerField("_min_chunk_size_in_bytes")).getValue();

You may want to follow the same convention here.
[Jini]: Unlike in the other cases, for MinChunkSizeInBytes, we are getting and storing the __value__ of the Field rather than the Field itself. Hence, I feel it might make more sense to not have 'Field' in this name. 

Thanks,
Jini.









Rest of the changes look ok.

Thanks,
Sharath (not a reviewer)


-----Original Message-----
From: Jini George
Sent: Thursday, November 02, 2017 10:24 AM
To: Serguei Spitsyn; [email protected]; 
[email protected]; [email protected]
Subject: Re: RFR: SA: JDK-8189798: SA cleanup - part 1

Could I please get one more review done for this ?

Thanks,
Jini.

On 10/27/2017 9:19 PM, Jini George wrote:

Thank you very much, Serguei.

-Jini.

On 10/27/2017 2:22 PM, [email protected] wrote:

Hi Jini,

The fix looks good to me.

Thanks,
Serguei


On 10/24/17 00:31, Jini George wrote:

Adding hotspot-dev too.

Thanks,
Jini.

On 10/24/2017 12:05 PM, Jini George wrote:

Hello,

As a part of SA next, I am working on writing a test case which
compares the fields and the types of the fields of the SA java
classes with the corresponding entries in the vmStructs tables.
This, to some extent, would help in preventing errors in SA due to
the changes in hotspot. As a precursor to this, I am in the process
of making some cleanup related changes (mostly in SA). I plan to
have the changes done in parts. For this webrev, most of the
changes are for:

1. Avoiding having some values being redefined in SA. Instead have
those exported through vmStructs, and read it in SA.
(CompactibleFreeListSpace::_min_chunk_size_in_bytes,
CompactibleFreeListSpace::IndexSetSize)

Redefinition of hotspot values in SA makes SA error prone, when the
value gets altered in hotspot and the corresponding modification
gets missed out in SA.

2. To remove some unused code (JNIid.java).
3. Add the missing "CMSBitMap::_bmStartWord" in vmStructs.
4. Modify variable names in SA and hotspot to match the counterpart
names, so that the comparison of the fields become easier. Most of
the changes belong to this group.

Could I please get reviews done for these precursor changes ?

JBS Id: https://bugs.openjdk.java.net/browse/JDK-8189798
webrev: http://cr.openjdk.java.net/~jgeorge/8189798/webrev.00/

Thank you,
Jini.




X-sender: <[email protected]>
X-Receiver: <[email protected]>
X-CreatedBy: MSExchange15
X-HeloDomain: mx.expurgate.net
X-ExtendedProps: 
BQBjAAoAqbJ+Vtsd1QgFADcAAgAADwA8AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5NYWlsUmVjaXBpZW50Lk9yZ2FuaXphdGlvblNjb3BlEQAAAAAAAAAAAAAAAAAAAAAADwAJAAAAQ0lBdWRpdGVkAgABBQBJAAIAAQUAYgAKAGcrAAB2AAAABQBkAA8ABAAAAEVkZ2U=
X-Source: SMTP:External Receive Connector
X-SourceIPAddress: 195.190.135.10
X-EndOfInjectedXHeaders: 7733
Received: from mx.expurgate.net (195.190.135.10) by smtpgw03.sap-ag.de
  (155.56.66.98) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 2 Nov
  2017 05:54:39 +0100
Received: from mx.expurgate.net (helo=localhost)
        by mx.expurgate.net with esmtp
        id 1eA7WZ-000EZw-D4
        for [email protected]; Thu, 02 Nov 2017 05:54:39 +0100
Received: from [156.151.31.69] (helo=ucsinet41.oracle.com)
        by mxtls.expurgate.net with ESMTPS (eXpurgate 4.2.1-3)
        (envelope-from <[email protected]>)
        id 59faa50b-7c01-c0a8033409dd-9c971f454783-3
        for <multiple-recipients>; Thu, 02 Nov 2017 05:54:38 +0100
Received: from aojmv0009 (unknown [137.254.59.6]) by ucsinet41.oracle.com with 
smtp
         id 4eb7_00c7_3ecf1c93_28fd_4a9f_97f0_f31de9ddb295;
        Thu, 02 Nov 2017 04:54:17 +0000
Received: from aojmv0009.oracle.com (localhost [127.0.0.1])
        by aojmv0009 (Postfix) with ESMTP id 15A99229CEC;
        Thu,  2 Nov 2017 04:57:26 +0000 (UTC)
X-Original-To: [email protected]
Delivered-To: [email protected]
Received: from ucsinet40.oracle.com (ucsinet40.oracle.com [156.151.31.68])  by 
aojmv0009 (Postfix) with ESMTP id 9CFF6229CC3;  Thu,  2 Nov 2017 04:57:20 +0000 
(UTC)
Received: from userp1040.oracle.com (unknown [156.151.31.81]) by  
ucsinet40.oracle.com with smtp
  (TLS: TLSv1/SSLv3,256bits,ECDHE-RSA-AES256-GCM-SHA384)
  id 37c3_8726_79982056_f63b_491d_a8be_57819e8c7dcc;
  Thu, 02 Nov 2017 04:54:08 +0000
Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])  by 
userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
  vA24s8KW028461
  (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);  
Thu, 2 Nov 2017 04:54:08 GMT
Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])  
by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s84O013997
  (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);  
Thu, 2 Nov 2017 04:54:08 GMT
Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8])  by 
aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s7KK017107;  Thu, 2 Nov 
2017 04:54:08 GMT
Received: from [10.177.158.142] (/10.177.158.142)  by default (Oracle Beehive 
Gateway v4.0)  with ESMTP ; Wed, 01 Nov 2017 21:54:07 -0700
Subject: Re: RFR: SA: JDK-8189798: SA cleanup - part 1
From: Jini George <[email protected]>
To: "[email protected]" <[email protected]>,
        "[email protected]" 
<[email protected]>,
        "[email protected]"
        <[email protected]>, <[email protected]>
References: <[email protected]>
  <[email protected]>
  <[email protected]>
  <[email protected]>
Organization: Oracle Corporation
Message-ID: <[email protected]>
Date: Thu, 2 Nov 2017 10:24:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
  Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <[email protected]>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0022.oracle.com [156.151.31.74]
X-BeenThere: [email protected]
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Technical discussion about the development of serviceability  technologies 
\(debugging, profiling, monitoring,  and management\)" 
<serviceability-dev.openjdk.java.net>
List-Unsubscribe: 
<http://mail.openjdk.java.net/mailman/options/serviceability-dev>,
  <mailto:[email protected]?subject=unsubscribe>
List-Archive: <http://mail.openjdk.java.net/pipermail/serviceability-dev/>
List-Post: <mailto:[email protected]>
List-Help: <mailto:[email protected]?subject=help>
List-Subscribe: 
<http://mail.openjdk.java.net/mailman/listinfo/serviceability-dev>,
  <mailto:[email protected]?subject=subscribe>
Errors-To: [email protected]
Sender: serviceability-dev <[email protected]>
X-purgate-ID: tlsNG-9b91ac/1509598479-00007C01-219CB02A/0/0
X-purgate-type: clean
X-purgate-size: 2000
X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de
Comment: eleven transport token 
MTU2LjE1MS4zMS42OQBzZXJ2aWNlYWJpbGl0eS1kZXYtYm91bmNlc0BvcGVuamRrLmphdmEubmV0AGF4ZWwuc2llYmVuYm9ybkBzYXAuY29tADgwYzQ2ZTI0N2Q2MTBlYjNiNTQ5MmE5YWE2NzJjNzJjN2NiNjcwNDQ=
X-purgate: This mail is considered clean (visit http://www.eleven.de for 
further information)
X-purgate: clean
X-SAP-SPAM-Status: clean
Return-Path: [email protected]
X-MS-Exchange-Organization-OriginalArrivalTime: 02 Nov 2017 04:54:39.6785
  (UTC)
X-MS-Exchange-Organization-OriginalClientIPAddress: 195.190.135.10
X-MS-Exchange-Organization-OriginalServerIPAddress: 155.56.66.98
X-MS-Exchange-Organization-AuthSource: DEWDFE13EDGE01.wdf.sap.corp
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: 
DEWDFE13EDGE01.wdf.sap.corp
X-MS-Exchange-Organization-Network-Message-Id: 
8fba1fcd-01cd-4a67-1ee6-08d521add313
X-MS-Exchange-Organization-OriginalSize: 7400
X-MS-Exchange-Organization-HygienePolicy: Standard
X-MS-Exchange-Organization-MessageHighPrecisionLatencyInProgress:
        
LSRV=DEWDFE13EDGE01.wdf.sap.corp:TOTAL-EDGE=11997.291|UTH=0.001|RST=11997.244|QS=0.029|CATCM-McAfeeTxRoutingAgent=0.011|CATCM=0.011|CAT=0.012;2017-11-02T08:14:36.969Z

Could I please get one more review done for this ?

Thanks,
Jini.

On 10/27/2017 9:19 PM, Jini George wrote:

Thank you very much, Serguei.

-Jini.

On 10/27/2017 2:22 PM, [email protected] wrote:

Hi Jini,

The fix looks good to me.

Thanks,
Serguei


On 10/24/17 00:31, Jini George wrote:

Adding hotspot-dev too.

Thanks,
Jini.

On 10/24/2017 12:05 PM, Jini George wrote:

Hello,

As a part of SA next, I am working on writing a test case which
compares the fields and the types of the fields of the SA java
classes with the corresponding entries in the vmStructs tables.
This, to some extent, would help in preventing errors in SA due to
the changes in hotspot. As a precursor to this, I am in the process
of making some cleanup related changes (mostly in SA). I plan to
have the changes done in parts. For this webrev, most of the
changes are for:

1. Avoiding having some values being redefined in SA. Instead have
those exported through vmStructs, and read it in SA.
(CompactibleFreeListSpace::_min_chunk_size_in_bytes,
CompactibleFreeListSpace::IndexSetSize)

Redefinition of hotspot values in SA makes SA error prone, when the
value gets altered in hotspot and the corresponding modification
gets missed out in SA.

2. To remove some unused code (JNIid.java).
3. Add the missing "CMSBitMap::_bmStartWord" in vmStructs.
4. Modify variable names in SA and hotspot to match the counterpart
names, so that the comparison of the fields become easier. Most of
the changes belong to this group.

Could I please get reviews done for these precursor changes ?

JBS Id: https://bugs.openjdk.java.net/browse/JDK-8189798
webrev: http://cr.openjdk.java.net/~jgeorge/8189798/webrev.00/

Thank you,
Jini.




X-sender: <[email protected]>
X-Receiver: <[email protected]>
X-CreatedBy: MSExchange15
X-HeloDomain: mx.expurgate.net
X-ExtendedProps: 
BQBjAAoAALN+Vtsd1QgFADcAAgAADwA8AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5NYWlsUmVjaXBpZW50Lk9yZ2FuaXphdGlvblNjb3BlEQAAAAAAAAAAAAAAAAAAAAAADwAJAAAAQ0lBdWRpdGVkAgABBQBJAAIAAQUAYgAKAIMrAAB2AAAABQBkAA8ABAAAAEVkZ2U=
X-Source: SMTP:External Receive Connector
X-SourceIPAddress: 194.145.224.110
X-EndOfInjectedXHeaders: 7704
Received: from mx.expurgate.net (194.145.224.110) by smtpgw03.sap-ag.de
  (155.56.66.98) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 2 Nov
  2017 05:54:46 +0100
Received: from mx.expurgate.net (helo=localhost)
        by mx.expurgate.net with esmtp
        id 1eA7Wg-0004R0-FP
        for [email protected]; Thu, 02 Nov 2017 05:54:46 +0100
Received: from [141.146.126.229] (helo=acsinet41.oracle.com)
        by mxtls.expurgate.net with ESMTPS (eXpurgate 4.3.1)
        (envelope-from <[email protected]>)
        id 59faa50f-65eb-c0a8029b09dd-8d927ee53db9-3
        for <multiple-recipients>; Thu, 02 Nov 2017 05:54:45 +0100
Received: from aojmv0009 (aojmv0009.oracle.com [137.254.59.6]) by 
acsinet41.oracle.com with smtp
         id 6461_15f0_154b24ba_5aa0_408c_88bd_1cdb37c9c8f4;
        Thu, 02 Nov 2017 04:54:31 +0000
Received: from aojmv0009.oracle.com (localhost [127.0.0.1])
        by aojmv0009 (Postfix) with ESMTP id 3B280229CF4;
        Thu,  2 Nov 2017 04:57:26 +0000 (UTC)
X-Original-To: [email protected]
Delivered-To: [email protected]
Received: from ucsinet40.oracle.com (ucsinet40.oracle.com [156.151.31.68])  by 
aojmv0009 (Postfix) with ESMTP id 9CFF6229CC3;  Thu,  2 Nov 2017 04:57:20 +0000 
(UTC)
Received: from userp1040.oracle.com (unknown [156.151.31.81]) by  
ucsinet40.oracle.com with smtp
  (TLS: TLSv1/SSLv3,256bits,ECDHE-RSA-AES256-GCM-SHA384)
  id 37c3_8726_79982056_f63b_491d_a8be_57819e8c7dcc;
  Thu, 02 Nov 2017 04:54:08 +0000
Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])  by 
userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
  vA24s8KW028461
  (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);  
Thu, 2 Nov 2017 04:54:08 GMT
Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])  
by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s84O013997
  (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);  
Thu, 2 Nov 2017 04:54:08 GMT
Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8])  by 
aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s7KK017107;  Thu, 2 Nov 
2017 04:54:08 GMT
Received: from [10.177.158.142] (/10.177.158.142)  by default (Oracle Beehive 
Gateway v4.0)  with ESMTP ; Wed, 01 Nov 2017 21:54:07 -0700
Subject: Re: RFR: SA: JDK-8189798: SA cleanup - part 1
From: Jini George <[email protected]>
To: "[email protected]" <[email protected]>,
        "[email protected]" 
<[email protected]>,
        "[email protected]"
        <[email protected]>, <[email protected]>
References: <[email protected]>
  <[email protected]>
  <[email protected]>
  <[email protected]>
Organization: Oracle Corporation
Message-ID: <[email protected]>
Date: Thu, 2 Nov 2017 10:24:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
  Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <[email protected]>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0022.oracle.com [156.151.31.74]
X-BeenThere: [email protected]
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Technical discussion about the development of the HotSpot runtime  subsystem 
<hotspot-runtime-dev.openjdk.java.net>
List-Unsubscribe: 
<http://mail.openjdk.java.net/mailman/options/hotspot-runtime-dev>,
  <mailto:[email protected]?subject=unsubscribe>
List-Archive: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/>
List-Post: <mailto:[email protected]>
List-Help: <mailto:[email protected]?subject=help>
List-Subscribe: 
<http://mail.openjdk.java.net/mailman/listinfo/hotspot-runtime-dev>,
  <mailto:[email protected]?subject=subscribe>
Errors-To: [email protected]
Sender: hotspot-runtime-dev <[email protected]>
X-purgate-ID: tlsNG-81024b/1509598486-000065EB-186BA960/0/0
X-purgate-type: clean
X-purgate-size: 2000
X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de
Comment: eleven transport token 
MTQxLjE0Ni4xMjYuMjI5AGhvdHNwb3QtcnVudGltZS1kZXYtYm91bmNlc0BvcGVuamRrLmphdmEubmV0AGF4ZWwuc2llYmVuYm9ybkBzYXAuY29tADE0ZjI2NjVmYTY4ZGRiOWMwNGJiMGU0MmE2Njk2M2ZiNWQxNzAyOGI=
X-purgate: This mail is considered clean (visit http://www.eleven.de for 
further information)
X-purgate: clean
X-SAP-SPAM-Status: clean
Return-Path: [email protected]
X-MS-Exchange-Organization-OriginalArrivalTime: 02 Nov 2017 04:54:46.7566
  (UTC)
X-MS-Exchange-Organization-OriginalClientIPAddress: 194.145.224.110
X-MS-Exchange-Organization-OriginalServerIPAddress: 155.56.66.98
X-MS-Exchange-Organization-AuthSource: DEWDFE13EDGE01.wdf.sap.corp
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: 
DEWDFE13EDGE01.wdf.sap.corp
X-MS-Exchange-Organization-Network-Message-Id: 
9365fa06-08de-47df-2865-08d521add74b
X-MS-Exchange-Organization-OriginalSize: 7380
X-MS-Exchange-Organization-HygienePolicy: Standard
X-MS-Exchange-Organization-MessageHighPrecisionLatencyInProgress:
        
LSRV=DEWDFE13EDGE01.wdf.sap.corp:TOTAL-EDGE=11990.260|UTH=0.001|RST=11990.260|CATCM-McAfeeTxRoutingAgent=0.004|CATCM=0.005|CAT=0.006;2017-11-02T08:14:37.016Z

Could I please get one more review done for this ?

Thanks,
Jini.

On 10/27/2017 9:19 PM, Jini George wrote:

Thank you very much, Serguei.

-Jini.

On 10/27/2017 2:22 PM, [email protected] wrote:

Hi Jini,

The fix looks good to me.

Thanks,
Serguei


On 10/24/17 00:31, Jini George wrote:

Adding hotspot-dev too.

Thanks,
Jini.

On 10/24/2017 12:05 PM, Jini George wrote:

Hello,

As a part of SA next, I am working on writing a test case which
compares the fields and the types of the fields of the SA java
classes with the corresponding entries in the vmStructs tables.
This, to some extent, would help in preventing errors in SA due to
the changes in hotspot. As a precursor to this, I am in the process
of making some cleanup related changes (mostly in SA). I plan to
have the changes done in parts. For this webrev, most of the
changes are for:

1. Avoiding having some values being redefined in SA. Instead have
those exported through vmStructs, and read it in SA.
(CompactibleFreeListSpace::_min_chunk_size_in_bytes,
CompactibleFreeListSpace::IndexSetSize)

Redefinition of hotspot values in SA makes SA error prone, when the
value gets altered in hotspot and the corresponding modification
gets missed out in SA.

2. To remove some unused code (JNIid.java).
3. Add the missing "CMSBitMap::_bmStartWord" in vmStructs.
4. Modify variable names in SA and hotspot to match the counterpart
names, so that the comparison of the fields become easier. Most of
the changes belong to this group.

Could I please get reviews done for these precursor changes ?

JBS Id: https://bugs.openjdk.java.net/browse/JDK-8189798
webrev: http://cr.openjdk.java.net/~jgeorge/8189798/webrev.00/

Thank you,
Jini.

Reply via email to