Hi Ujwal,
MBeanOperationInfo:163:
Since the values are fixed, you could more concisely just compare impact
>=0 and impact <= UNKNOWN.
257/263: I don't see a reason to change the toString in the default
case for getImpact().
A suggestion would be to introduce an Enum for the action values and the
corresponding new
method; perhaps deprecating the current method (or not).
The enum would use the same values as currently and so internally the
implementation does not
change significantly.
$.02, Roger
On 11/7/2017 6:05 AM, Ujwal Vangapally wrote:
Kindly review the fix for bug below.
https://bugs.openjdk.java.net/browse/JDK-8024352
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8024352/webrev.00/
Thanks,
Ujwal.
