Re: CSR review request for: 8187289 NotifyFramePop request is not cleared if JVMTI_EVENT_FRAME_POP is disabled

[serguei.spit...@oracle.com]

Thanks a lot, Dan. I've made the suggested change. Thanks, Serguei On 11/16/17 17:27, Daniel D. Daugherty wrote: Also reviewed the CSR. Added a comment about one typo/grammar change, but it's finalized so I did not actually make the change. Dan On 11/16/17 8:01 PM, serguei.spit...@oracle.com wrote: Chris, I've also moved the statements about compatibility risk from the "Description" section to the "Compatibility Risk Description" special section. Thanks, Serguei On 11/16/17 16:56, serguei.spit...@oracle.com wrote: Hi Chris, Thank you a lot for looking at the CSR. On 11/16/17 16:34, Chris Plummer wrote: Hi Serguei, I've read through it and it looks fine except for one minor thing: "The solution is to clear all bound NotifyFramePop requests when a stack frame is popped." I think this could be made more clear. It makes it sound like you clear *all* NotifyFramePop requests the first time *any* frame is popped. I've changed it to:   "The solution is to clear the NotifyFramePop requests related to the popped frame when a stack frame is popped." Does is sound better? This is the first time I've dealt with a CSR. What do I need to do to mark it reviewed? It is the first time for me too. :) I think, you have to add yourself to the reviewed-by list. I've just added you to this list. Also, it could be Ok to add comments. Thanks, Serguei thanks, Chris On 11/16/17 4:25 PM, serguei.spit...@oracle.com wrote: Dan and Chris Could one of you, please, review the CSR for 8187289:   https://bugs-stage.openjdk.java.net/browse/JDK-8191098 Bug is:   https://bugs-stage.openjdk.java.net/browse/JDK-8187289 Approved webrev:   http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/ This CSR covers a change in behavior, not in the JVMTI spec. We decided that the JVMTI NotifyFramePop is intuitive enough and does not need an update. Thanks, Serguei