Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

[Chris Plummer]

Hi Sharath, Do we have any other examples of testing SA tool classes in this manner? I couldn't find any. I don't see any tests that directly test the classes in the sun/jvm/hotspot/tools. Instead I think we rely on testing the tools that use them such as jstack, pstack, and clhsdb. The only reference to ClassDump I could find is  by the clhsdb buildreplayjars command. I guess was this is leading to is do we even officially support running ClassDump stand alone as you are doing when you reproduce this bug? If so, are there other tool classes that we also need better testing of. thanks, Chris On 11/27/17 10:15 PM, Sharath Ballal wrote: Can I get one more review please ?   Thanks, Sharath     From: Sharath Ballal Sent: Wednesday, November 22, 2017 2:53 PM To: Sundararajan Athijegannathan; serviceability-dev@openjdk.java.net Subject: RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException   Thanks Sundar.     Thanks, Sharath     From: Sundararajan Athijegannathan Sent: Tuesday, November 21, 2017 7:38 PM To: serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException   +1 -Sundar On 21/11/17, 3:26 PM, Sharath Ballal wrote: I have made minor modification to the test (added @bug and removed @modules). The revised webrev is   http://cr.openjdk.java.net/~sballal/8184982/webrev.01/     Thanks, Sharath     From: Sharath Ballal Sent: Tuesday, November 21, 2017 12:27 PM To: serviceability-dev@openjdk.java.net Subject: RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException   Gentle reminder.     Thanks, Sharath     From: Sharath Ballal Sent: Tuesday, November 14, 2017 10:31 AM To: serviceability-dev@openjdk.java.net Subject: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException   Hello,   Pls review the code changes and testcase for the following issue.   Bug ID:  https://bugs.openjdk.java.net/browse/JDK-8184982   Webrev: http://cr.openjdk.java.net/~sballal/8184982/webrev.00/   Thanks, Sharath