Re: DOC RFR (XS): 8182413: jdwp-protocol is generated without a DOCTYPE directive

Thu, 30 Nov 2017 01:58:53 -0800

On 11/30/17 00:40, [email protected] wrote:
Hi Alan,

Thank you for reviewing this!


On 11/30/17 00:09, Alan Bateman wrote:


On 30/11/2017 07:45, [email protected] wrote:
:
 
     void document(PrintWriter writer) {
+ writer.println("<!DOCTYPE html>");
         writer.println("<html><head><title>" + comment() + "</title></head>");
         writer.println("<body bgcolor=\"white\">");
         for (Node node : components) {

This looks okay to me. Anything else missing while you are there?

The Copyright element is not present:
 <p><em><a href="">Copyright</a> © 1993, 2017, Oracle and/or its affiliates. All rights reserved.</em></p>

Not sure, it is realy needed in the jdwp-protocol.html as it is an internal part
of the jdwp-spec.html which already has this Copyright line at the bottom.

Thanks,
Sergei

Not sure if we need the charset element:
  <meta charset="utf-8">

Thanks,
Serguei

-Alan


Reply via email to