On 11/30/17 10:26 AM, Roman Kennke wrote:
Hi Mandy,
thanks for reviewing! I think Erik Ö. already pushed it for me.
A minor comment that GCMemoryManager could take an enum to indicate
the type of this GC action (major vs minor). This can be a future
cleanup.
This may be overly restrictive: some GCs may not necessarily provide a
major/minor distinction, but have only one GC manager (e.g. epsilon),
or may provide 3 or more GC managers (e.g. 'minor' partial (or young)
GC, 'intermediate' concurrent GC, 'intermediate or major' concurrent
full GC, 'major' STW last-ditch full GC...).
Right - there will be more than 2 enums and major and major are just
examples that could let GC notififer to determine the message based on
the type. This is minor and just a thought that can be considered in
the future.
Thanks.
Mandy
