Opps sorry one more thing:

    /**
* Get the contents of the output buffer (stdout and stderr) as list of strings.
     * Output will be split by system property 'line.separator'.

the doc comment needs to be updated e.g:

* Output will be split at new-lines as recognized by java.io.BufferedReader.readLine()

Thanks,
David

On 14/01/2018 8:47 AM, David Holmes wrote:
Looks good - thanks. I'll sponsor for you.

David

On 13/01/2018 11:05 PM, [email protected] wrote:
Webrev updated with buffered reader lines() suggested by David.

   http://cr.openjdk.java.net/~gadams/8031482/webrev.01/

On 1/11/18 11:28 AM, Gary Adams wrote:
Here's a simple fix to the split pattern when output lines are using mixed line
separators in the same outputstream . e.g. split("\r\n|\n")

  Issue: https://bugs.openjdk.java.net/browse/JDK-8031482
  Webrev: http://cr.openjdk.java.net/~gadams/JDK-8031482

testing in progress ...


Reply via email to