Hi Paru,
Thank you for the update! Could you, please, rearrange a couple of more places in both files? 66 BreakpointEvent bpe = startToMain("HelloWorld"); 67 ReferenceType referenceType = (ClassType)bpe.location().declaringType(); 68 69 mainThread = bpe.thread(); 70 // VM has started, but hasn't started running the test program yet. 71 EventRequestManager requestManager = vm().eventRequestManager(); 72 73 Location loc = findLocation(referenceType, 3); 74 75 BreakpointRequest bpRequest = requestManager.createBreakpointRequest(loc); I'd suggest to move the lines 68,69 after the line 75. Also, the empty lines 72, 74 are not needed. I'm not sure, the line 70 with the comment is placed correctly or needed at all. This line needs an update of "request1": 107 //request1.addClassFilter("x"); Extra space before '!' and missed space before '{' : 115 if ( !stepCompleted){ Let's simplify/unify the tracing lines below further: 130 System.out.println("Agent: StepEvent: line#=" + event.location().lineNumber() 131 + " event=" + event); . . . 141 System.out.println("Agent: BreakpointEvent " + 142 " at " + locStr + " in thread: " + thread); Something like this would be better: 130 System.out.println("StepEvent at " + event.location()); . . . 141 System.out.println("BreakpointEvent at " + event.location()); The lines 139 and 140 can be removed: 139 ThreadReference thread = event.thread(); 140 String locStr = "" + event.location(); Thanks, Serguei On 2/13/18 23:01, Paru Somashekar wrote: Hi Serguei, |
- RFR 8196324: Update FilterMatch & FilterNoM... Paru Somashekar
- Re: RFR 8196324: Update FilterMatch & ... serguei.spit...@oracle.com
- Re: RFR 8196324: Update FilterMatch &a... Paru Somashekar
- Re: RFR 8196324: Update FilterMatc... serguei.spit...@oracle.com
- Re: RFR 8196324: Update Filter... Paru Somashekar
- Re: RFR 8196324: Update F... serguei.spit...@oracle.com
- Re: RFR 8196324: Upda... Paru Somashekar