Hi Chris,
Looks good.
Thanks,
Serguei
On 2/14/18 14:30, Chris Plummer wrote:
Hello,
Please review the following simple fix for a compiler warning:
https://bugs.openjdk.java.net/browse/JDK-8196909
diff --git
a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
--- a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
+++ b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
@@ -398,7 +398,7 @@
return instr;
}
- *mask = htonl(-1 << (32 - m));
+ *mask = htonl((uint32_t)(~0) << (32 - m));
return s;
}
Tested with all open and closed jdb, jdwp, and jdi test suites on all
supported platforms.
thanks,
Chris