Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris

[serguei.spit...@oracle.com]

Hi Daniil, It looks good to me. It seems, you have been able to reproduce this failure, and with this fix the test does not fail anymore. Is that right? Just wanted to be sure. Thanks, Serguei On 2/20/18 16:14, Daniil Titov wrote: Hi Serguei,   A new version of the webrev that has these strings reformatted is at http://cr.openjdk.java.net/~dtitov/8170541/webrev.02/   Thank you!   Best regards, Daniil       From: "serguei.spit...@oracle.com" <serguei.spit...@oracle.com> Date: Tuesday, February 20, 2018 at 3:00 PM To: Daniil Titov <daniil.x.ti...@oracle.com>, "serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net> Subject: Re: RFR 8170541: serviceability/jdwp/AllModulesCommandTest.java fails intermittently on Windows and Solaris   Hi Daniil, Interesting issue... Thank you for finding to the root cause so quickly! The fix looks good. Could I ask you to reformat these lines to make the L54 shorter ?:   54                 System.out.println("[" + getClass().getName() + "] Only " + bytesRead + " bytes of " + dataLength +   55                         " were read in the first packet. Reading the rest..."); Thanks, Serguei On 2/20/18 09:24, Daniil Titov wrote: Please review the changes that fix intermittent failure of serviceability/jdwp/AllModulesCommandTest.java test.   The problem here is that for a large data the JDWP agent (socketTransport_writePacket() method in src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c ) sends 2 packets and in some cases only the first packet is received at the time when the test reads the reply from the JDWP agent. Since the test does not check that all data is received in the first packet the correlation between commands and replies became broken (the unread second packet is read by the next command and the reply for the next command is read by the next after next command and so on).   Bug: https://bugs.openjdk.java.net/browse/JDK-8170541 Webrev: http://cr.openjdk.java.net/~dtitov/8170541/webrev.01   The tests ran successfully with Mach5.     Best regards, Daniil