On 8/03/2018 11:21 PM, Yasumasa Suenaga wrote:
Could you review and sponsor it?
Mach5 test result on submit repo:
I encountered DebuggerException when hsdis is located on long path as
Location of hsdis:
cannot open shared object file: No such file or directory
In Java_sun_jvm_hotspot_asm_Disassembler_load_1library(), buffer which
uses for library path is defined as below:
I copied JVM_MAXPATHLEN related code to sadis.c from
os/posix/include/jvm_md.h and os/windows/include/jvm_md.h .
I don't think this code has the same concern that the code in jvm_md.h
claims** to have, so a simple use of MAXPATHLEN should be fine on all
** The posix jvm_md.h code is historical and I don't think we have to be
concerned either about a 4095 definition of MAXPATHLEN or that the VM
and libraries may have been compiled on different Linux versions!
My only concern with the current change is whether a 4K on stack buffer
might cause any issues?
I added noreg-hard label on this ticket because this issue is available
when disassembling on coredump.