Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

[Roger Riggs]

Hi Martin,

Good recommendation; pushed.

Thanks, Roger



On 3/21/2018 3:31 PM, Martin Buchholz wrote:

On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs <roger.ri...@oracle.com <mailto:roger.ri...@oracle.com>> wrote:

    -    void *      test = (void *) 0x99999999;
    +    void *      test = (void *) 0x99999999ul;

Martin's 15th law: Never use "l" in a numeric constant unless the constant is 0xCafeBabel,

so 0x99999999UL