Hi David,

> > I think you should keep your original fix since it now properly
> > handles null arguments at the same attach-on-demand layer as the
> > Linux code that you quoted.
> >
> > Handling this in args array processing would also be possible
> > as David suggests, but it would bother me that Linux and Solaris
> > lower attach-on-demand layers would have different behaviors.
> 
> They already do have completely different behaviours. Linux handles NULL
> at the Java layer by inserting empty strings!

I had another look at the implementations on the various platforms.

You are right, linux, aix and mac would write empty strings on java layer - but 
the enque mechanisms of these platforms looks quite different to Solaris. 
However, for Windows, where the implementation is different again, the handling 
of null params happens in the c-native code. For Solaris I would see the best 
place in the native code as well.

So if you don't mind I would keep my change and annotate you and Dan as 
reviewers, ok?

Thanks
Christoph

Reply via email to