Hi Thomas,

I like the fix, too.

Maybe you can add example output before and after sorting to the bug.

Thanks
Christoph

> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> boun...@openjdk.java.net] On Behalf Of serguei.spit...@oracle.com
> Sent: Dienstag, 3. April 2018 03:53
> To: Thomas Stüfe <thomas.stu...@gmail.com>; Hotspot dev runtime
> <hotspot-runtime-...@openjdk.java.net>; serviceability-
> d...@openjdk.java.net
> Subject: Re: RFR(xxs): 8200384: jcmd help output should be sorted
> 
> Hi Thomas,
> 
> Added the serviceability-dev mailing list as it is a Serviceability area.
> 
> The fix looks good to me.
> One question:
>   Could you, please, post the sorted help output?
>   It is interesting how does it look like when sorted.
> 
> Thanks,
> Serguei
> 
> 
> On 3/28/18 13:08, Thomas Stüfe wrote:
> > Hi all,
> >
> > may I get reviews for this tiny trivial change which causes jcmd help
> > output (the command list) to be sorted?
> >
> > bug: https://bugs.openjdk.java.net/browse/JDK-8200384
> > webrev:
> > http://cr.openjdk.java.net/~stuefe/webrevs/8200384-jcmd-help-
> sorted/webrev.00/webrev/
> >
> > Thanks!
> >
> > Best Regards, Thomas

Reply via email to