Hi Gary,

On 5/04/2018 4:18 AM, Gary Adams wrote:
Getting the sources ready for the next Solaris developer studio toolchain.

   Issue: https://bugs.openjdk.java.net/browse/JDK-8199782
   Webrev: http://cr.openjdk.java.net/~gadams/8199782/webrev.00/

This update conditionally disables some new error checks, if the
new toolchain is used.

This looks odd:

 231     DISABLED_WARNINGS_solstudio := $(DISABLED_WARNINGS_solstudio), \

as it is self-referential. Should you use a different variable name? Is there an issue if this variable has not been set?

Otherwise seems okay.

Thanks,
David

Reply via email to