> On 9 Apr 2018, at 20:31, Alan Bateman <alan.bate...@oracle.com> wrote:
> 
>> On 09/04/2018 18:54, Martin Buchholz wrote:
>> Another little cleanup to make Google's race detector happy.
>> 
>> 8201327: Make Sensor deeply immutably thread safe
>> http://cr.openjdk.java.net/~martin/webrevs/jdk/Sensor-init/ 
>> <http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/Sensor-init/>
>> https://bugs.openjdk.java.net/browse/JDK-8201327
>> 
> This looks okay to me,

+1

> except maybe the "initially false" and "initially 0" comments as they are 
> just documenting the default values and don't add anything.

Yeah, I’ve done this before too, especially when removing default values ( as 
if to prevent them from inadvertently creeping back in ).

-Chris.

Reply via email to