Hi Sharath,
It looks good to me.
Thanks,
Serguei
On 5/23/18 00:08, Sharath Ballal wrote:
Can I have one more review pls ?
Thanks,
Sharath
-----Original Message-----
From: Chris Plummer
Sent: Tuesday, May 22, 2018 12:41 PM
To: Sharath Ballal; serviceability-dev
Subject: Re: RFR: JDK-8193639 - tests failing intermittently with Error
attaching to process: Can't create thread_db agent!
Hi Sharath,
The changes look fine, but I would request you check this change in as a
subtask of 8193639 and keep 8193639 open.
thanks,
Chris
On 5/21/18 11:02 PM, Sharath Ballal wrote:
Hello,
Requesting reviews for
ID: https://bugs.openjdk.java.net/browse/JDK-8193639
Webrev: http://cr.openjdk.java.net/~sballal/8193639/webrev.00/
<http://cr.openjdk.java.net/%7Esballal/8193639/webrev.00/>
We are seeing intermittent problems with the calls to threaddb in
solaris failing. We are not sure of the reason for the failure as it
is not being logged as of now.
I have added failure code to the exception messages when there is a
failure. Next time when it fails, we should be able to know the reason.
Thanks,
Sharath
