Igor,
It looks good.
Thank you a lot for taking care about this!
Thanks,
Serguei
On 5/23/18 12:44, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8199380/webrev.00/
2370 lines changed: 2370 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources AOD tests from VM
testbase? these tests test hotspot's attach-on-demand.
As usually w/ VM testbase code, these tests are old, they have been run in
hotspot testing for a long period of time. Originally, these tests were run by
a test harness different from jtreg and had different build and execution
schemes, some parts couldn't be easily translated to jtreg, so tests might have
actions or pieces of code which look weird. In a long term, we are planning to
rework them.
JBS: https://bugs.openjdk.java.net/browse/JDK-8199380
webrev: http://cr.openjdk.java.net/~iignatyev//8199380/webrev.00/index.html
testing: :vmTestbase_vm_aod test group
Thanks,
-- Igor
