Thanks for the comments Bernd. I will work on them and send a webrev once done.
Thanks, Sharath From: Bernd Eckenfels [mailto:e...@zusammenkunft.net] Sent: Wednesday, May 30, 2018 10:54 PM To: serviceability-dev Subject: Re: RFR: JDK-8199729 - Usage Logger open sourcing Would it be possible to remove all the duplicate configuration code from the PostVMInitHook and just call run() { UsageLoggerClient.logJavaUsage(); }? This way all config code can be in one place. I also wonder if the ORCL_ prefix can and should be removed from all constants? Beside that I would return getAbsoluteFile() from the priveledged sections. Gruß Bernd -- https://Bernd.eckenfels.net On Wed, May 30, 2018 at 6:21 PM +0200, "Sharath Ballal" <HYPERLINK "mailto:sharath.bal...@oracle.com"sharath.bal...@oracle.com> wrote: Hello, Requesting reviews for Usage Logger open sourcing (earlier known as Usage Tracker). ID: https://bugs.openjdk.java.net/browse/JDK-8199729 Webrev: http://cr.openjdk.java.net/~sballal/8199729/webrev.00/ Mach5 run has been successful for Usage Logger tests and hs-tier1, hs-tier2. Thanks, Sharath
