Looks good.
I'll sponsor this change.
/Jesper

> On 31 May 2018, at 19:59, Leonid Mesnik <leonid.mes...@oracle.com> wrote:
> 
> Thank you for review.
> 
> It becomes a part of hotspot_tier2_runtime now and executed in tier2.  (Also 
> in tier3 and higher tiers with other options.)
> 
> Leonid
> 
>> On May 31, 2018, at 10:47 AM, Vladimir Kozlov <vladimir.koz...@oracle.com> 
>> wrote:
>> 
>> Looks fine. In what tier the test will be run?
>> 
>> Thanks,
>> Vladimir
>> 
>> On 5/31/18 10:11 AM, Leonid Mesnik wrote:
>>> Hi
>>> Please review following tiny fix which marks test 
>>> serviceability/dcmd/compiler/CompilerQueueTest.java as intermittent and 
>>> exclude it from tier1.
>>> The test intermittently fails (1-2 times in 1000 runs) because of 
>>> https://bugs.openjdk.java.net/browse/JDK-8158374.
>>> Tier1 should be stable and don't contain any tests with known issues. It 
>>> should always pass if there are no regression introduced by new fix. So 
>>> this test should be excluded from tier1.
>>> Also fix marks this test with corresponding key like it is done for jdk, 
>>> langtoools and nashorn tests.
>>> webrev: http://cr.openjdk.java.net/~lmesnik/8204103/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8204103
>>> I verified that tier1 runs and doesn't contain this test now.
>>> See more information about intermittent keyword in 
>>> https://bugs.openjdk.java.net/browse/JDK-8075565
>>> Leonid
> 

Reply via email to