+1
Chris
On 6/5/18 1:09 AM, [email protected] wrote:
Hi David,
The fix looks good to me.
Also, it makes the initialization more simple.
Thanks,
Serguei
On 6/4/18 22:57, David Holmes wrote:
Ping! Please.
Thanks,
David
On 1/06/2018 1:39 PM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8199882
webrev: http://cr.openjdk.java.net/~dholmes/8199882/webrev/
The lazy loading (not initialization, despite the method names) of
the AbstractOwnableSynchronizer class (needed for deadlock detection
and stack dumps) has caused a number of problems due to the
potential for loading exceptions (specifically OOME), which result
in code that does not anticipate exceptions, encountering them.
The bug discusses a number of possible solutions but the chosen one
is to simply pre-load the AOS class along with the numerous other
core classes that get pre-loaded.
This does of course add a small increment to startup time, but it
should be negligible in the overall scheme of things and not
something to be unduly concerned about (Claes has commented in chat
that he doesn't see it as an issue.)
Testing:
- mach5 tier1,2,3
- java/lang/management/*
- java/util/concurrent/*
- compiler/uncommontrap/TestDeoptOOM.java
Thanks,
David
