Thank you, Dan!
Serguei
On 6/6/18 16:52, Daniel D. Daugherty wrote:
On 6/6/18 6:44 PM, serguei.spit...@oracle.com wrote:
Hi Dan,
Thank you for the review!
As always, you're welcome.
The fix has been already pushed.
Yup. I noticed that after I finished the review.
I hope, it is Okay with you.
Of course. I'm playing catch up after being off-the-air for
two weeks so I don't/didn't expect you guys to wait for me.
Are you Okay with the release note sub-task? :
https://bugs.openjdk.java.net/browse/JDK-8192891
It tells:
A NotifyFramePop request was only cleared if the
JVMTI_EVENT_FRAME_POP is enabled.
Now it is always cleared when the corresponding frame is popped,
regardless of whether the JVMTI_EVENT_FRAME_POP is enabled or not.
Looks like a good note to me.
Dan
Thanks,
Serguei
On 6/6/18 13:59, Daniel D. Daugherty wrote:
On 5/23/18 3:33 PM, Alex Menkov wrote:
Hi all,
Please take a look at a fix for
https://bugs.openjdk.java.net/browse/JDK-8187289
webrev: http://cr.openjdk.java.net/~amenkov/notifyFramePop/webrev/
src/hotspot/share/prims/jvmtiEventController.cpp
No comments.
src/hotspot/share/prims/jvmtiExport.cpp
No comments.
test/hotspot/jtreg/serviceability/jvmti/NotifyFramePop/NotifyFramePopTest.java
No comments.
test/hotspot/jtreg/serviceability/jvmti/NotifyFramePop/libNotifyFramePopTest.c
No comments.
I compared this patch with Serguei's last patch and I _think_ I
understand
the differences between the two version... but it has been a while...
Thumbs up.
Dan
CSR for the issue: https://bugs.openjdk.java.net/browse/JDK-8191467
--alex
