Thanks, Goetz. The "Error: cannot attach" was put in deliberately so
that we get to know that this is not getting tested. I can change this
to retain the old behaviour of skipping the tests if we cannot attach.
Thanks,
Jini.
On 7/12/2018 3:41 PM, Lindenmaier, Goetz wrote:
Hi Jini,
I had a look at your change.
It makes tests fail if shouldSAAttach returns false.
Now, these tests say "Errror: cannot attach",
while before they would terminate silently.
It is not an Error if the SA can not attach.
You can reproduce this by just changing
Platform.shouldSAAttach() to always return false.
I'll run the patch throuqh our nightly tests to
see whether they pass mac.
Best regards,
Goetz.
-----Original Message-----
From: serviceability-dev [mailto:serviceability-dev-
boun...@openjdk.java.net] On Behalf Of Jini George
Sent: Montag, 9. Juli 2018 20:45
To: serviceability-dev@openjdk.java.net
Subject: RFR: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X
Requesting reviews for enabling SA tests on OS X for Mach5.
https://bugs.openjdk.java.net/browse/JDK-8199700
Webrev: http://cr.openjdk.java.net/~jgeorge/8199700/webrev.00/
The changes are mostly to include the addition of sudo privileges to the
SA launchers for OSX if Platform.shouldSAAttach() fails. Some tests
(those using clhsdb) have been refactored to use ClhsdbLauncher for ease
of maintainence. This also avoids checks for Platform.shouldSAAttach()
for corefile related test cases. More details have been provided in JIRA.
Thanks,
Jini.
