Hi Dan,

Looks good to me. Thanks for cleaning up the noise.

Chris

On 7/25/18 12:03 PM, Daniel D. Daugherty wrote:
Greetings,

I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so
I need a single (R)eviewer for the following fix:

  JDK-8208205 ProblemList tests that fail due to 'Error attaching to
              process: Can't create thread_db agent!'
  https://bugs.openjdk.java.net/browse/JDK-8208205

Here's the diff:

$ hg diff test/hotspot/jtreg/ProblemList.txt
diff -r 628718bf8970 test/hotspot/jtreg/ProblemList.txt
--- a/test/hotspot/jtreg/ProblemList.txt    Wed Jul 25 12:32:06 2018 -0400 +++ b/test/hotspot/jtreg/ProblemList.txt    Wed Jul 25 14:47:58 2018 -0400
@@ -74,14 +74,43 @@
 # :hotspot_runtime

 runtime/CompressedOops/UseCompressedOops.java 8079353 generic-all
+runtime/SharedArchiveFile/SASymbolTableTest.java 8193639 solaris

 #############################################################################

 # :hotspot_serviceability

-serviceability/sa/ClhsdbCDSCore.java                 8207832 linux-x64
-serviceability/sa/TestRevPtrsForInvokeDynamic.java   8191270 generic-all
-serviceability/sa/sadebugd/SADebugDTest.java         8163805 generic-all
+serviceability/sa/ClhsdbAttach.java 8193639 solaris
+serviceability/sa/ClhsdbCDSCore.java 8207832 linux-x64
+serviceability/sa/ClhsdbField.java 8193639 solaris
+serviceability/sa/ClhsdbFindPC.java 8193639 solaris
+serviceability/sa/ClhsdbInspect.java 8193639 solaris
+serviceability/sa/ClhsdbJdis.java 8193639 solaris
+serviceability/sa/ClhsdbJhisto.java 8193639 solaris
+serviceability/sa/ClhsdbJstack.java 8193639 solaris
+serviceability/sa/ClhsdbLongConstant.java 8193639 solaris
+serviceability/sa/ClhsdbPmap.java 8193639 solaris
+serviceability/sa/ClhsdbPrintAll.java 8193639 solaris
+serviceability/sa/ClhsdbPrintAs.java 8193639 solaris
+serviceability/sa/ClhsdbPrintStatics.java 8193639 solaris
+serviceability/sa/ClhsdbPstack.java 8193639 solaris
+serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java 8193639 solaris
+serviceability/sa/ClhsdbScanOops.java 8193639 solaris
+serviceability/sa/ClhsdbSource.java 8193639 solaris
+serviceability/sa/ClhsdbSymbol.java 8193639 solaris
+serviceability/sa/ClhsdbSymbolTable.java 8193639 solaris
+serviceability/sa/ClhsdbThread.java 8193639 solaris
+serviceability/sa/ClhsdbWhere.java 8193639 solaris
+serviceability/sa/DeadlockDetectionTest.java 8193639 solaris
+serviceability/sa/JhsdbThreadInfoTest.java 8193639 solaris
+serviceability/sa/sadebugd/SADebugDTest.java 8163805 generic-all
+serviceability/sa/TestClassDump.java 8193639 solaris
+serviceability/sa/TestCpoolForInvokeDynamic.java 8193639 solaris
+serviceability/sa/TestDefaultMethods.java 8193639 solaris
+serviceability/sa/TestG1HeapRegion.java 8193639 solaris
+serviceability/sa/TestRevPtrsForInvokeDynamic.java 8191270 generic-all
+serviceability/sa/TestType.java 8193639 solaris
+serviceability/sa/TestUniverse.java 8193639 solaris

 #############################################################################


In the above diff, it looks like I deleted these entries:

-serviceability/sa/ClhsdbCDSCore.java 8207832 linux-x64
-serviceability/sa/TestRevPtrsForInvokeDynamic.java   8191270 generic-all
-serviceability/sa/sadebugd/SADebugDTest.java         8163805 generic-all

What I really did was delete the spaces (like most of the other entries
in the hotspot ProblemList:

+serviceability/sa/ClhsdbCDSCore.java 8207832 linux-x64
+serviceability/sa/sadebugd/SADebugDTest.java 8163805 generic-all
+serviceability/sa/TestRevPtrsForInvokeDynamic.java 8191270 generic-all

I also put those entries in sort order which is why a 'diff -w'
wasn't used...


Thanks, in advance, for any questions, comments or suggestions.

Dan



Reply via email to