Hi Chris,
The smallest allowed metaspace size for the test is 9MB. In both
cases (when the metaspace size is set to 9Mb and to 16 Mb) the
expected OutOfMemoryError is thrown and the test passes.
I did update the patch to use the smallest settings.
Webrev: http://cr.openjdk.java.net/~dtitov/8207364/webrev.02
The test uses a custom class loader to load a class from the byte
array read from the predefined specified class file. The incorrect
path passed to the test made the test fail to read this class file.
java.lang.RuntimeException: Exception when reading file
'./bin/nsk/jvmti/ResourceExhausted/Helper.class'
at
nsk.jvmti.ResourceExhausted.resexhausted003.fileBytes(resexhausted003.java:74)
at
nsk.jvmti.ResourceExhausted.resexhausted003.run(resexhausted003.java:89)
at
nsk.jvmti.ResourceExhausted.resexhausted003.main(resexhausted003.java:129)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:115)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.io.FileNotFoundException:
./bin/nsk/jvmti/ResourceExhausted/Helper.class (No such file or
directory)
at java.base/java.io.FileInputStream.open0(Native Method)
at java.base/java.io.FileInputStream.open(FileInputStream.java:219)
at
java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
at
nsk.jvmti.ResourceExhausted.resexhausted003.fileBytes(resexhausted003.java:64)
... 8 more
Best regards,
Daniil
On 7/25/18, 9:09 PM, "Chris Plummer" <chris.plum...@oracle.com> wrote:
Hi Daniil,
After reading some old comments I added to JDK-6606767, I
wonder if
bumping the metaspace size all the way up to 16m is the right
thing to
do. It seems the test wants to exhaust the metaspace, so maybe
it should
be set it to the smallest allowed size. Is the test still
exhausting the
metaspace even when it is 16M. Is there a smaller size that will
also work?
Also, regarding the class path, what impact was this bug
having on the test?
thanks,
Chris
On 7/25/18 4:32 PM, serguei.spit...@oracle.com wrote:
> Hi Daniil,
>
> It looks good to me.
> What is the need to increase the metaspace size?
>
> Thanks,
> Serguei
>
>
> On 7/25/18 16:11, Daniil Titov wrote:
>> Hello,
>>
>> Please review the change that fix the test issue. The fix
increases
>> the metaspace size and corrects the path to the class files.
>>
>> Webrev: http://cr.openjdk.java.net/~dtitov/8207364/webrev.01/
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8207364
>>
>> Thanks!
>>
>> Best regards,
>> Daniil
>>
>>
>>
>
