Hi Alex,
I'm Okay with this keyword removal.
Thank you for checking.
Thanks,
Serguei
On 8/9/18 14:59, Alex Menkov wrote:
Hi Serguei,
On 08/07/2018 20:53, serguei.spit...@oracle.com wrote:
Hi Alex,
It looks good to me - good start!
The only question I have is that the following line is dropped for
both tests:
@key intermittent
Just wanted to double check if the SQE team is still using it
to mark the intermittently failing tests.
SQE tells that they do not use it.
The keyword was added to intermittently failing tests
(looks like jdk9 has too many such tests, so the goal way to simplify
failure analysis).
Also one of the goals of shell to java conversion is to resolve tests
instability, so it looks logical to remove the keyword as part of the
conversion fix.
--alex
Thanks,
Serguei
On 8/7/18 17:09, Alex Menkov wrote:
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8209109
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/webrev/
This is a first step in shell to java conversion of com/sun/jdi tests
The fix introduces base classes to work with jdb and converts couple
tests.
--alex
