Hi Jc,
It looks good in general, thank you for taking care about this! A couple of comments though. http://cr.openjdk.java.net/%7Ejcbeyler/8203356/webrev.00/test/hotspot/jtreg/serviceability/jvmti/VMEvent/libVMEventTest.c.html 58 (*jvmti)->GetClassSignature(jvmti, klass, &signature, &generic); 59 60 if (JNI_ENV_PTR(jni)->ExceptionOccurred(JNI_ENV_ARG(jni))) { 61 JNI_ENV_PTR(jni)->FatalError( 62 JNI_ENV_ARGS2(jni, "Failed during the GetClassSignature call")); 63 } The JVMTI error code, returned by GetClassSignature has to be checked, not JNI ExceptionOccurred. Also, I'd suggest to check for signature to be non-NULL. Also, the indent in the VMEventRecursionTest.java has to be 4 (as we normally use for java code), not 2. Thanks, Serguei On 8/22/18 16:20, JC Beyler wrote:
|
- RFR (S) 8203356: VM Object Allocation Collector... JC Beyler
- Re: RFR (S) 8203356: VM Object Allocation ... Hohensee, Paul
- Re: RFR (S) 8203356: VM Object Allocation ... serguei.spit...@oracle.com
- Re: RFR (S) 8203356: VM Object Allocat... serguei.spit...@oracle.com
- Re: RFR (S) 8203356: VM Object All... JC Beyler
- Re: RFR (S) 8203356: VM Object... serguei.spit...@oracle.com
- Re: RFR (S) 8203356: VM O... Alex Menkov
- Re: RFR (S) 8203356: VM Object Allocation ... Chris Plummer