On 8/24/18 12:27, Alex Menkov wrote:


On 08/24/2018 12:24, serguei.spit...@oracle.com wrote:
Hi Alex,


It looks good to me.

One minor comment:

http://cr.openjdk.java.net/~amenkov/sh2java/jdbSolarisTimeout/webrev/test/jdk/com/sun/jdi/lib/jdb/JdbCommand.java.udiff.html

+ // untrace [methods] -- stop tracing method entrys and/or exits

   A typo: entrys => entries

This is exact citation from jdb help :)

I see - thanks! :)

Thanks,
Serguei


--alex


No need in new webrev if you fix this.


Thanks,
Serguei


On 8/24/18 11:54, Alex Menkov wrote:
Hi all,

Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8203393
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/jdbSolarisTimeout/webrev/

The fix converts the test to java (and this resolves the timeouts)

--alex


Reply via email to