Hi Jc,
It looks much better now.
BTW did you run all the tests?
test/hotspot/jtreg/vmTestbase/nsk/share/jni/JNIreferences.cpp
"(V" should be "()V":
// notify another thread that JNI local reference has been created
- JNI_ENV_PTR(env)->CallVoidMethod(JNI_ENV_ARG_3(env,
createWicket, JNI_ENV_PTR(env)->GetMethodID(JNI_ENV_ARG_4(env, klass,
"unlock", "()V"))));
+ env->CallVoidMethod(createWicket, env->GetMethodID(klass,
"unlock", "(V"));
// wait till JNI local reference can be released (it will
heppen then we will leave the method)
- JNI_ENV_PTR(env)->CallVoidMethod(JNI_ENV_ARG_3(env,
deleteWicket, JNI_ENV_PTR(env)->GetMethodID(JNI_ENV_ARG_4(env, klass,
"waitFor", "()V"))));
+ env->CallVoidMethod(deleteWicket, env->GetMethodID(klass,
"waitFor", "(V"));
}
--alex
On 08/29/2018 22:01, JC Beyler wrote:
Hi all,
A follow-up to Igor's work on getting tests in C++, I am working on
simplifying the macros in the tests from the vmTestBase. The full change
being a bit too large, I'm cutting it up in pieces to be easier to
review and integrate.
Here is the first part, it changes all vmTestbase tests outside the
vmTestbase/jvmti subfolder:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8210182/webrev.01/
<http://cr.openjdk.java.net/%7Ejcbeyler/8210182/webrev.01/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8210182
Thanks!
Jc
