Re: RFR (M) 8210198: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[A-F] tests

Wed, 05 Sep 2018 12:20:02 -0700

Hi JC,

In bytecodes001.cpp the formatting could use some improvement:

 130     if (meth_tab[meth_ind].stat == JNI_TRUE) {
 131         mid = env->GetStaticMethodID(cl,
 132             meth_tab[meth_ind].name, meth_tab[meth_ind].sig);
 133     } else {
 134         mid = env->GetMethodID(cl,
 135             meth_tab[meth_ind].name, meth_tab[meth_ind].sig);
 136     }

In getclsldr003.cpp, getfldecl001.cpp, getfldecl002.cpp, and getfldecl004.cpp, no need to compare with JNI_TRUE. Just negate the _expression_.:

  98     if (env->IsSameObject(classloader, cl) != JNI_TRUE) {

Otherwise looks good.

Thanks for the cleanup,

Chris

On 9/4/18 4:12 PM, JC Beyler wrote:
Hi all,

Continuing the removal of the JNI_ENV* macros, I have done about half of the JVMTI Get[A-F] methods. The whole change for jvmti/GetXX tests was about 2k of changes so it seemed best to just divide it into two parts (from my approximation there will be 2 more webrevs to finish the umbrella item JDK-8209547).

The change is straightforward as before, just a bit repetitive:

I tested this in release mode for the tests that were modified.

Thanks,
Jc


Reply via email to