Re: RFR (L) 8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests

Thu, 06 Sep 2018 23:31:57 -0700

Hi Jc,

It looks to me.
One minor comment.

http://cr.openjdk.java.net/%7Ejcbeyler/8210429/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetMethodDeclaringClass/declcls001/declcls001.cpp.udiff.html
-        mid = JNI_ENV_PTR(env)->GetStaticMethodID(JNI_ENV_ARG(env, cl),
+        mid = env->GetStaticMethodID(cl,
             name, sig);
I'd suggest to replace to place the call to just one line.


No need for another webrev if you fix it.

Thanks,
Serguei


On 9/5/18 18:39, JC Beyler wrote:
Hi all,

Continuing the removal of the JNI_ENV* macros, I have done the other half of the JVMTI Get[G-Z] methods. The final JVMTI test refactoring will come in a final webrev after this one.

The change is straightforward as before, just a bit repetitive:

I tested this in release mode for the tests that were modified.

Thanks for your reviews,
Jc

Reply via email to