Re: RFR: JDK-8208468: [TESTBUG] nsk/jdb/locals/locals002: fails with "Prompt is not received during ... milliseconds"

[Gary Adams]

Patch attached.

On 9/12/18, 3:35 PM, Chris Plummer wrote:

Looks good. I filed JDK-8210668 to address to root issue.

Chris

On 9/12/18 7:27 AM, Gary Adams wrote:

The print statements in the locals002 test have been observed to interfere with the output from commands, replies and prompts used in the synchronization of operations between the debugger and debuggee. This change will remove the print statements. A follow up bug will be filed for longer term investigation of the character at a time output which leaves a larger window for the output interruption

that occurs.

  Issue: https://bugs.openjdk.java.net/browse/JDK-8208468

Proposed update:

diff --git a/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java b/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java --- a/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java +++ b/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java

@@ -81,7 +81,7 @@
        int[]   arrVar
                               )
    {

- System.out.println("Arguments but no locals"); // locals002.BREAKPOINT_LINE1

+       int x = 3; // locals002.BREAKPOINT_LINE1
    }

    static void allKindsOfLocals()  {
@@ -97,6 +97,6 @@
        int[]   arrVar    = new int[5];

        for (int j = 0; j < 5 ; j++) arrVar[j] = j;

- System.out.println("Locals but no arguments"); // locals002.BREAKPOINT_LINE2

+       int x = 4; // locals002.BREAKPOINT_LINE2
    }
 }

# HG changeset patch
# User gadams
# Date 1536839201 14400
#      Thu Sep 13 07:46:41 2018 -0400
# Node ID 9cd3738f4a6d83a2053c22f996d726722f4d9057
# Parent  8abb0fa2c3340c6bbd76385e9b12ad188921f095
8208468: [TESTBUG] nsk/jdb/locals/locals002: fails with "Prompt is not received 
during ... milliseconds"
Reviewed-by: cjplummer, amenkov

diff --git 
a/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java 
b/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java
--- a/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java
+++ b/test/hotspot/jtreg/vmTestbase/nsk/jdb/locals/locals002/locals002a.java
@@ -81,7 +81,7 @@
        int[]   arrVar
                               )
    {
-       System.out.println("Arguments but no locals"); // 
locals002.BREAKPOINT_LINE1
+       int x = 3; // locals002.BREAKPOINT_LINE1
    }
 
    static void allKindsOfLocals()  {
@@ -97,6 +97,6 @@
        int[]   arrVar    = new int[5];
 
        for (int j = 0; j < 5 ; j++) arrVar[j] = j;
-       System.out.println("Locals but no arguments"); // 
locals002.BREAKPOINT_LINE2
+       int x = 4; // locals002.BREAKPOINT_LINE2
    }
 }