Hi Alex,
The fix looks good to me.
Thanks,
Serguei
On 9/17/18 10:49 AM, Alex Menkov wrote:
Hi all,
please review small fix:
http://cr.openjdk.java.net/~amenkov/sh2java/timeout/webrev.01/
It fixes
https://bugs.openjdk.java.net/browse/JDK-8210725
- accordingly the logs of the failing tests, they work as expected,
but sometimes (busy environment?) there is no reply from jdb for 60
seconds, so tests throw exception.
The timeout can be removed at all (so timeouts would be handled by
general jtreg timeout mechanism), but prefer keep smaller timeout for
jdb reply, but apply timefactor to the value.
Also the change fixes
https://bugs.openjdk.java.net/browse/JDK-8210748
- in the case of error additional logging is done to indicate certain
point where the error occurs.
--alex
