Hi Jini, Thanks for the review.
Thanks, Fairoz > -----Original Message----- > From: Jini George > Sent: Friday, September 21, 2018 4:07 PM > To: Fairoz Matte <fairoz.ma...@oracle.com>; serviceability- > d...@openjdk.java.net > Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 > when loading dumped core > > Hi Fairoz, > > This looks good to me. One nit which got missed out in the original change > also is that in saproc.cpp, the following comments > > 452 > 453 // Pstack_iter() proc_stack_f callback prior to Nevada-B159 > > 476 // Pstack_iter() proc_stack_f callback in Nevada-B159 or later > 477 /*ARGSUSED*/ > > would not be required anymore. And we would not need the wrapper to the > callback routine fill_cframe_list() -- as in, we would need only one routine > with the appropriate arguments passed. But you are free to ignore this since > this was not done as a part of the original change. > > Thanks, > Jini (Not a Reviewer). > > > > On 9/20/2018 7:06 PM, Fairoz Matte wrote: > > Hi, > > > > Kindly review the backport of "JDK-8164383 : jhsdb dumps core on > > Solaris 12 when loading dumped core" to 8u > > > > Webrev - http://cr.openjdk.java.net/~fmatte/8164383/webrev.00/ > > > > JBS bug - https://bugs.openjdk.java.net/browse/JDK-8164383 > > > > JDK9 changeset - > > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ce3eaa22b582 > > > > JDK9 review thread - > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-October > > /020543.html > > > > Thanks, > > Fairoz > >
