Re: RFR (M) 8210689: Remove the multi-line old C style for string literals

Fri, 21 Sep 2018 10:17:13 -0700

Hi JC,

I didn't realize you intended to move all the strings into a "const char*" first. Seems unnecessary, and I think not as easy to read:

 138         const char* debug_str =
 139             "TEST FAILED: JVMTI_EVENT_CLASS_LOAD event received for\n"
 140             "\t a primitive class/array of primitive types with the signature \"%s\"\n";
 141         NSK_COMPLAIN1(debug_str, sig);

vs

 138         NSK_COMPLAIN1("TEST FAILED: JVMTI_EVENT_CLASS_LOAD event received for\n"
 139                       "\t a primitive class/array of primitive types with the signature \"%s\"\n",
 140                       sig);

or

 138         NSK_COMPLAIN1(
 139             "TEST FAILED: JVMTI_EVENT_CLASS_LOAD event received for\n"
 140             "\t a primitive class/array of primitive types with the signature \"%s\"\n",
 141             sig);

thanks,

Chris

On 9/21/18 8:00 AM, JC Beyler wrote:
Hi all,

Is anyone motivated on a Friday to review this ? :)

It should be fairly straightforward :-)

Thanks,
Jc
On Tue, Sep 18, 2018 at 12:07 PM JC Beyler <jcbey...@google.com> wrote:
Hi all,

Could I have a review for this webrev: 


Let me know what you think,
Jc

--

Thanks,
Jc


Reply via email to