Hi Alex,

Looks good.

thanks,

Chris

On 9/27/18 2:32 PM, Alex Menkov wrote:
Hi all,

please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8203928
webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/

Some details:

ImmutableResourceTest.java
  - required compile/run args are specified by using jtreg tag options;

JITDebug.java
  - was not able to reproduce failures described (looks like that it's something ancient). Actually we use dt_socket transport on Windows for a long time without any issues;   - replaced Runtime.exec with ProcessBuilder, used some /test/lib stuff, fixed some minor issues;

connect/spi/JdiLoadedByCustomLoader.java
redefine/RedefineTest.java
redefineMethod/RedefineTest.java
  - implemented compilation tasks in java, removed shell files;

PrivateTransportTest.java (was test/jdk/com/sun/jdi/PrivateTransportTest.sh)
  - just converted the test from shell to java.

--alex



Reply via email to