Patch attached.
I'll need a sponsor for the push.
On 10/8/18, 3:58 PM, serguei.spit...@oracle.com wrote:
Hi Gary,
+1
Thanks,
Serguei
On 10/8/18 11:30, Chris Hegarty wrote:
The updated link looks ok to me.
-Chris
On 8 Oct 2018, at 19:15, Gary Adams <gary.ad...@oracle.com> wrote:
Alan suggested in the bug report for the broken link from the
jdwp-protocol
spec to the java/lang/ThreadGroup documentation to simply remove the
href link. Another possibility is to simply update the link to
include the java.base
subdirectory.
I don't think the doc structure changes very often so either solution
seems fine to me.
diff --git a/make/data/jdwp/jdwp.spec b/make/data/jdwp/jdwp.spec
--- a/make/data/jdwp/jdwp.spec
+++ b/make/data/jdwp/jdwp.spec
@@ -2185,7 +2185,7 @@
"in this thread group. Threads and thread groups in child "
"thread groups are not included. "
"A thread is alive if it has been started and has not yet
been stopped. "
- "See <a
href=../../../api/java/lang/ThreadGroup.html>java.lang.ThreadGroup </a>
+ "See <a
href=../../api/java.base/java/lang/ThreadGroup.html>java.lang.ThreadGroup
</a>
"for information about active ThreadGroups.
(Out
(threadGroupObject group "The thread group object ID. ")
# HG changeset patch
# User gadams
# Date 1539084795 14400
# Tue Oct 09 07:33:15 2018 -0400
# Node ID 701e593445ba186e192a637c7f390b1490cdc8b5
# Parent e25291a90cbab444e58a3aa937f3534d536af607
8211324: Link to java.lang.ThreadGroup in JDWP spec is broken
Reviewed-by: sspitsyn, chegar, alanb
diff --git a/make/data/jdwp/jdwp.spec b/make/data/jdwp/jdwp.spec
--- a/make/data/jdwp/jdwp.spec
+++ b/make/data/jdwp/jdwp.spec
@@ -2185,7 +2185,7 @@
"in this thread group. Threads and thread groups in child "
"thread groups are not included. "
"A thread is alive if it has been started and has not yet been
stopped. "
- "See <a
href=../../../api/java/lang/ThreadGroup.html>java.lang.ThreadGroup </a>
+ "See <a
href=../../api/java.base/java/lang/ThreadGroup.html>java.lang.ThreadGroup </a>
"for information about active ThreadGroups.
(Out
(threadGroupObject group "The thread group object ID. ")
