Looks good to me.
--alex
On 10/12/2018 14:25, JC Beyler wrote:
Yes they do, they have run on my dev machine and I'm submitting it on
the submit repo (though that will test build and not the tests from what
I understood) :)
Jc
On Fri, Oct 12, 2018 at 2:16 PM Hohensee, Paul <hohen...@amazon.com
<mailto:hohen...@amazon.com>> wrote:
This looks fine. Do the tests run correctly after the transform?____
__ __
paul____
__ __
*From: *serviceability-dev
<serviceability-dev-boun...@openjdk.java.net
<mailto:serviceability-dev-boun...@openjdk.java.net>> on behalf of
JC Beyler <jcbey...@google.com <mailto:jcbey...@google.com>>
*Date: *Friday, October 12, 2018 at 4:41 PM
*To: *"serviceability-dev@openjdk.java.net
<mailto:serviceability-dev@openjdk.java.net>"
<serviceability-dev@openjdk.java.net
<mailto:serviceability-dev@openjdk.java.net>>
*Subject: *RFR (L) 8212082: Remove the NSK_CPP_STUB macros from
remaining vmTestbase/jvmti/[sS]*____
__ __
Hi all,____
I am continuing the NSK_CPP_STUB removal with this next webrev
(before last one, the next one I'll send out will be removing
NSK_CPP_STUB entirely).____
__ __
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212082/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8212082/webrev.00/>____
Bug: https://bugs.openjdk.java.net/browse/JDK-8212082____
__ __
The change is still straight-forward though, since it is just doing
the same NSK_CPP_STUB removal as others. ____
__ __
Thanks,____
Jc____
--
Thanks,
Jc