Thanks Jc for the review..
From: JC Beyler <jcbey...@google.com> Sent: Thursday, October 18, 2018 9:41 PM To: Fairoz Matte <fairoz.ma...@oracle.com> Cc: David Holmes <david.hol...@oracle.com>; serviceability-dev@openjdk.java.net Subject: Re: [8u-backport] RFR: 8211909: JDWP Transport Listener: dt_socket thread crash Hi Fairoz, I compared the original and the port, it looks good to me, Jc On Thu, Oct 18, 2018 at 12:55 AM Fairoz Matte <HYPERLINK "mailto:fairoz.ma...@oracle.com"fairoz.ma...@oracle.com> wrote: Thanks David, for the review... > -----Original Message----- > From: David Holmes > Sent: Thursday, October 18, 2018 1:20 PM > To: Fairoz Matte <HYPERLINK > "mailto:fairoz.ma...@oracle.com"fairoz.ma...@oracle.com>; serviceability- > HYPERLINK "mailto:d...@openjdk.java.net"d...@openjdk.java.net > Subject: Re: [8u-backport] RFR: 8211909: JDWP Transport Listener: dt_socket > thread crash > > Looks good ! Thanks for doing the backport to 8u. > > David > > On 18/10/2018 5:37 PM, Fairoz Matte wrote: > > Hi, > > > > Kindly review the backport of "8211909: JDWP Transport Listener: > dt_socket thread crash" to 8u > > > > code is almost cleanly applied. > > > > Webrev - http://cr.openjdk.java.net/~fmatte/8211909/webrev.00/ > > > > JBS bug - https://bugs.openjdk.java.net/browse/JDK-8211909 > > > > JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/a4d4c609d70c > > > > Review thread - http://mail.openjdk.java.net/pipermail/serviceability- > dev/2018-October/025515.html > > > > Thanks, > > Fairoz > > -- Thanks, Jc
